Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Node.js 17.5 compatibility #11381

Merged
merged 3 commits into from
Feb 13, 2022
Merged

fix Node.js 17.5 compatibility #11381

merged 3 commits into from
Feb 13, 2022

Commits on Feb 11, 2022

  1. fix Node.js 17.5 compatibility 

    The tc39 async iterator helpers spec adds `.map` to async iterators and Node added support for that.

As part of spec compliance Node uses defineProperty to add these properties.

This PR fixes setting `.map` in Mongoose over the property.

As a side note: it might make sense for Mongoose to deprecate `.map` since it's mutative which makes it named the same but with a different behavior from the tc39 iterator helpers proposal `.map`
    @benjamingr
    benjamingr committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    2f697da View commit details
    Browse the repository at this point in the history

  2. second fix

    @benjamingr
    benjamingr committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    268737c View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2022

  1. fixup! run linter

    @benjamingr
    benjamingr committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    8667e53 View commit details
    Browse the repository at this point in the history