fix: propagate lean options to child schemas

Fix #5914
Automattic · Dec 20, 2017 · ccec46f · ccec46f
1 parent 4e64596
commit ccec46f
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/lib/queryhelpers.js b/lib/queryhelpers.js
@@ -19,7 +19,9 @@ exports.preparePopulationOptions = function preparePopulationOptions(query, opti
   var pop = utils.object.vals(query.options.populate);
 
   // lean options should trickle through all queries
-  if (options.lean) pop.forEach(makeLean);
+  if (options.lean) {
+    pop.forEach(makeLean(options.lean));
+  }
 
   return pop;
 };
@@ -37,7 +39,9 @@ exports.preparePopulationOptionsMQ = function preparePopulationOptionsMQ(query,
   var pop = utils.object.vals(query._mongooseOptions.populate);
 
   // lean options should trickle through all queries
-  if (options.lean) pop.forEach(makeLean);
+  if (options.lean) {
+    pop.forEach(makeLean(options.lean));
+  }
 
   return pop;
 };
@@ -207,7 +211,9 @@ exports.applyPaths = function applyPaths(fields, schema) {
  * @param {Object} option
  */
 
-function makeLean(option) {
-  option.options || (option.options = {});
-  option.options.lean = true;
+function makeLean(val) {
+  return function(option) {
+    option.options || (option.options = {});
+    option.options.lean = val;
+  };
 }