Merge pull request #6852 from hellodigit/4.x-version-number-errors

feat(error): add version number to VersionError (4.x)
Automattic · Aug 14, 2018 · 0e0dba0 · 0e0dba0
2 parents 471cadc + ce7fb11
commit 0e0dba0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/lib/error/version.js b/lib/error/version.js
@@ -13,10 +13,11 @@ var MongooseError = require('./');
  * @api private
  */
 
-function VersionError(doc) {
+function VersionError(doc, currentVersion) {
   MongooseError.call(this, 'No matching document found for id "' + doc._id +
-    '"');
+    '" version ' + currentVersion);
   this.name = 'VersionError';
+  this.version = currentVersion;
 }
 
 /*!

diff --git a/lib/model.js b/lib/model.js
@@ -258,16 +258,17 @@ Model.prototype.$__save = function(options, callback) {
       var doIncrement = VERSION_INC === (VERSION_INC & _this.$__.version);
       _this.$__.version = undefined;
 
+      var key = _this.schema.options.versionKey;
+      var version = _this.getValue(key) || 0;
+
       if (numAffected <= 0) {
         // the update failed. pass an error back
-        var err = new VersionError(_this);
+        var err = new VersionError(_this, version);
         return callback(err);
       }
 
       // increment version if was successful
       if (doIncrement) {
-        var key = _this.schema.options.versionKey;
-        var version = _this.getValue(key) | 0;
         _this.setValue(key, version + 1);
       }
     }

diff --git a/test/versioning.test.js b/test/versioning.test.js
@@ -265,6 +265,7 @@ describe('versioning', function() {
     function test4(err, a, b) {
       assert.ok(/No matching document/.test(err), err);
       assert.equal(a._doc.__v, 5);
+      assert.equal(err.version, b._doc.__v - 1);
       a.set('arr.0.0', 'updated');
       var d = a.$__delta();
       assert.equal(a._doc.__v, d[0].__v, 'version should be added to where clause');