Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin cheerio to latest rc.12 #494

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

cossssmin
Copy link
Collaborator

Fixes issues with breaking changes from cheerio@1.0.0 until it's handled somehow upstream.

See discussion for more info.

fixes issue with breaking changes from cheerio@1.0.0
@cossssmin cossssmin requested a review from jrit August 15, 2024 07:54
@cossssmin
Copy link
Collaborator Author

Related: #493

@cossssmin
Copy link
Collaborator Author

@jrit could you please have a look at this? It's currently breaking for many users because of cheerio: either because of Node 18 requirement or in other cases & is converted to & because of how they also changed htmlparser2 options.

We need to release a patch that pins cheerio until they resolve this entire debacle.

Copy link
Collaborator

@jrit jrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@jrit jrit merged commit aecda77 into Automattic:master Aug 16, 2024
3 checks passed
@jrit
Copy link
Collaborator

jrit commented Aug 16, 2024

@cossssmin can I give you publish permissions for juice on npm? what's your username there?

@cossssmin
Copy link
Collaborator Author

Sure, I’m cossssmin there too:

https://www.npmjs.com/~cossssmin

@ainsly
Copy link

ainsly commented Aug 17, 2024

Just a quick appreciation post for addressing this quickly. Was tough to narrow down which package was actually causing that strange issue that popped up out of nowhere. Kudos 👏 🎉

All my ‍ and other html entities suddenly started appearing fulltext in my email templates. Time to add more tests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants