Subscriptions: Fix Subscribed button alignment

[pkuliga]

For some themes (especially Lettre) the "✓ Subscribed" button alignment had some issues, like the button label was not centered or the button was too wide.

Proposed changes:

It fixes the "✓ Subscribed" alignment by centering it vertically and removing the custom width.

"Lettre" theme

Before

After

There should be no difference for themes where those issues didn't occur, like "Twenty Twenty-Four".

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Subscribe to the blog using the Subscribe block
• Make sure the "✓ Subscribed" button rendered by the Subscribe block looks as expected
• Check different themes

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/subscribe-centered branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/subscribe-centered
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for May 7, 2024 (scheduled code freeze on May 6, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[simison]

How come we use ID here instead of class? 🤔 Makes me thinking something is using to scroll to it later on.

Not a super biggie, but ID is also problematic for having multiple blocks on the page since there should always be just one unique ID per page load.

[pkuliga]

Agree, but at the same time, I want to be consistent with the rest of the code.

Not sure why we have IDs there. I prefer to remove them in a separate PR if we want to do it.

[pkuliga]

There are already some styles attached to it in premium themes:
fbhepr%2Sfrnepu%3Sshyy%3Q%2522fhofpevor%2Qfhozvg%2522%26qrsf%3Q%26ersf%3Q%26cngu%3Q%26uvfg%3Q%26glcr%3Q%26keq%3Q%26aa%3Q17%26fv%3Qshyy%26frnepunyy%3Qgehr%26fv%3Qshyy-og

[simison]

Can we keep the submit ID but start using something else for this new case? E.g. is-subscribed class?

[pkuliga]

Like the idea, will try that 👍

[simison]

Results are pretty good with my test post:

Editor

Before PR

After PR

Last block especially is interesting; it's set to 100% width with the button on new line, and it now behaves more like I'd expect.

The other examples with button on "new line" don't look so great tho. We should probably skip the centering on those? They're effectively "left aligned" style.

[pkuliga]

Thanks for testing @simison! I applied some fixes, could you take a look once more?

How do I get the "Narrow example"? I didn't test this one since I don't know how to create it.

[simison]

Narrow example was just Subscribe block with button on new line inside a 50/50 column:

[simison]

Aight, it's looking good now.