Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Add test IDs to VideoPress components for integration tests #30486

Merged
merged 4 commits into from
May 10, 2023
Merged

[RNMobile] Add test IDs to VideoPress components for integration tests #30486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11d3f8b
[not verified] Add test ID to uploading video view
fluiddot May 5, 2023
290bc5c
Add test ID to player component
fluiddot May 5, 2023
eb6d106
[not verified] Add changelog
fluiddot May 5, 2023
0ce05da
Merge branch 'trunk' into rnmobile/videopress-add-test-ids
jhnstn May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/videopress/changelog/rnmobile-videopress-add-test-ids
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: added

VideoPress block: Add test IDs to query elements in integration tests
1 change: 1 addition & 0 deletions ...ackages/videopress/src/client/block-editor/blocks/video/components/player/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ export default function Player( { isSelected, attributes } ) {
html={ html }
onWindowEvents={ { message: onSandboxMessage } }
viewportProps="user-scalable=0"
testID="videopress-player"
onLoadEnd={ onLoadEnd }
/>
) }
Expand Down
2 changes: 1 addition & 1 deletion ...ient/block-editor/blocks/video/components/videopress-uploader/uploader-progress.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ const UploaderProgress = ( { file, onDone, onReset, isInteractionDisabled } ) =>
<Text style={ retryUploadTextStyle }>{ retryMessage }</Text>
</>
) : (
<View style={ videoPressIconContainerStyle }>
<View style={ videoPressIconContainerStyle } testID="videopress-uploading-video">
<Icon icon={ VideoPressIcon } { ...iconStyle } />
</View>
) }
Expand Down