-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mailchimp Block: Replace submit button with inner button block #16170
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16170 Scheduled Jetpack release: July 7, 2020. |
Other than the PHPCS rule comment above, everything looks good, thanks! |
Replace generic phpcs:ignore rule with WordPress.Security.EscapeOutput.OutputNotEscaped Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Caution: This PR has changes that must be merged to WordPress.com |
r210103-wpcom |
Fixes #15712
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Does this pull request change what data or activity we track or use?
Prerequisites:
Testing instructions:
Before:
After:
Proposed changelog entry for your changes: