Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailchimp Block: Replace submit button with inner button block #16170

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

aaronrobertshaw
Copy link
Contributor

Fixes #15712

Changes proposed in this Pull Request:

  • Replace the SubmitButton in the Mailchimp block with new shared Button block.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • No.

Does this pull request change what data or activity we track or use?

  • No.

Prerequisites:

  • Mailchimp account
  • Site with Mailchimp connection setup
  • Post with Mailchimp block created prior to applying this PR's changes

Testing instructions:

  1. Apply this PR
  2. On the frontend, visit the post containing the previous version of Mailchimp block
  3. Confirm that the block displays and functions as it did before
  4. Edit the post
  5. Confirm Mailchimp block displays and has correct settings
  6. Update the Mailchimp block's button using new settings controls provided by button block
  7. Save the post
  8. Re-visit the post on the frontend and confirm display and function of block.

Before:

Screen Shot 2020-06-16 at 5 23 05 pm

After:

Screen Shot 2020-06-16 at 5 44 07 pm

Proposed changelog entry for your changes:

  • Update Mailchimp block to use new shared Button block.

@jetpackbot
Copy link

jetpackbot commented Jun 16, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16170

Scheduled Jetpack release: July 7, 2020.
Scheduled code freeze: June 30, 2020

Generated by 🚫 dangerJS against 3534168

Copons
Copons previously approved these changes Jun 17, 2020
@Copons Copons added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Team Review labels Jun 17, 2020
@fgiannar
Copy link
Contributor

Other than the PHPCS rule comment above, everything looks good, thanks!

extensions/blocks/mailchimp/mailchimp.php Outdated Show resolved Hide resolved
@jeherve jeherve added this to the 8.7 milestone Jun 18, 2020
@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Jun 18, 2020
Replace generic phpcs:ignore rule with WordPress.Security.EscapeOutput.OutputNotEscaped

Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
@fgiannar fgiannar added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 18, 2020
@fgiannar fgiannar dismissed jeherve’s stale review June 18, 2020 13:58

Change already committed

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello aaronrobertshaw! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D45260-code before merging this PR. Thank you!
This revision will be updated with each commit to this PR

@scruffian scruffian merged commit 23c919c into master Jun 24, 2020
@scruffian scruffian deleted the update/replace-mailchimp-submit-button branch June 24, 2020 11:18
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 24, 2020
jeherve added a commit that referenced this pull request Jun 30, 2020
@jeherve
Copy link
Member

jeherve commented Jul 7, 2020

r210103-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Mailchimp Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mailchimp: Replace with SubmitButton new Button block
7 participants