Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests, Docs: Remove references to dops-components #12388

Merged
merged 4 commits into from
May 15, 2019

Conversation

ockham
Copy link
Contributor

@ockham ockham commented May 15, 2019

Changes proposed in this Pull Request:

Remove some references to (now-defunct) dops-components. Among other things, their npm's path was still added to NODE_PATH for some of our tests. Furthermore, some docs still had references to dops-components.

Discovered while working on #12381.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

N/A

Testing instructions:

Production code isn't affected. Try running updated tests though:

yarn test-client
yarn test-gui
yarn test-modules

Proposed changelog entry for your changes:

  • Tests, Docs: Remove references to dops-components

@ockham ockham added Docs [Status] Needs Review To request a review from Crew. Label will be renamed soon. Unit Tests labels May 15, 2019
@ockham ockham requested a review from a team May 15, 2019 20:16
@ockham ockham requested a review from a team as a code owner May 15, 2019 20:16
@ockham ockham self-assigned this May 15, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello ockham! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D28260-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against 64a3c5c

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! This looks good to me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 15, 2019
@jeherve jeherve added this to the 7.4 milestone May 15, 2019
@kraftbj kraftbj merged commit f7110d2 into master May 15, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 15, 2019
@kraftbj kraftbj deleted the remove/dops-components-references branch May 15, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants