Try/publicize api #10367
Closed
Try/publicize api #10367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connection data access is intermingled with HTML generation. This moves connection data access out of ui.php and into publicize-jetpack.php to decouple it from the UI. This is a cleaner design and allows the data to be accessed for other purposes.
Adding test coverage for: - done_sharing_post: testing flagged and published posts - get_services_connected: testing service list - get_filtered_connection_data: testing simple connection data with no filtering
Adding unit tests for three existing filters in Publicize: - 'wpas_submit_post?' - 'publicize_checkbox_global_default' - 'publicize_checkbox_default' These filters were previously difficult to test since they were being applied within HTML generation code. Now that HTML generation is separated from the connection retrieving/filtering, it is a good time to add unit tests.
A previous iteration had method 'get_filtered_connection_data' in Publicize_UI, so the test and other references were calling it from there. This updates those references now that the method has been moved into Publicize class.
'disabled' parameter value was from 'get_filtered_connection_data' return was an HTML string an an early iteration but is now a boolean. This commit updates the associated test case to check new data format.
HTML indenting was incorrect in Publicize_UI::get_metabox_form_connected(). This commit fixes the whitespace.
Updated Publicize form generation to use new boolean parameter value to correctly disable checkboxes when required.
Cleaning up some minor issues identified by phpcs in get_filtered_connection_data. This function is legacy code that has been moved over, so it continues to have code style issues. More major refactoring would be necessary to fix the rest...
Cleaning up low-hanging fruit on coding styles, including: - whitespace - comments - yoda conditions
Modifies Publicize_UI::get_filtered_connection_data() to gracefully handle the case where there is no current post and the post_id parameter is unset. This condition is now handled by not disabling any of the connection checkboxes. Previously, this case would cause a PHP error. Also adding test cases to exercise this case. props @kraftbj
Reining in some especially long lines in Publicize_UI::get_filtered_connection_data(). No functional changes intended.
ockham
added
[Status] In Progress
[Focus] Blocks
|
Closing in favor of #10372. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reboot of sorts of #9963, to help us develop the Calypso side. Essentially #9955 plus
modules/publicize/class-jetpack-publicize-gutenberg.php. Don't merge.