This repository has been archived by the owner on Feb 22, 2019. It is now read-only.
Switch to hash.js from sha1 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hash.js pulling just sha1 is 2.3k gzipped, while sha1 is 8k. Switch to save some bytes and align with what calypso uses.
sirreal
reviewed
Jul 18, 2018
There was a problem hiding this comment.
Seems like a win, tests are passing.
Updated usage appears to align with docs:
var sha512 = require('hash.js/lib/hash/sha/512'); sha512().update('abc').digest('hex');
Any specific ways we should be testing this? I'm really not familiar with i18n-calypso inner workings.
|
Testing... Yeah. The existing unit tests sort of cover this, but there are no tests (that I can find) that explicitly cover the caching bit. I'll see if I can work something up. |
|
@sirreal added tests for hashed lookups. They pass on master as well as here. |
sirreal
approved these changes
Jul 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hash.js, using justsha1is 2.3k gzipped, whilesha1is 8k.Switch to save some bytes and align with what calypso uses.