Safeguard array in WP_Job_Manager_Settings::input_capabilities #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedebian
added
[Type] Bug
[Pri] Normal
Customer Report
fjorgemota
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2625
Changes Proposed in this Pull Request
This PR adds safeguard in input_capabilities to avoid invalid capabilities to be passed to get_capabilities_and_roles.
It also adds data type safeguard in get_capabilities_and_roles in order to avoid invalid array access.
Lastly, it also updates yoast/phpunit-polyfills in composer.json/lock in order to make the tests compatible with the latest PHPUnit version.
Testing Instructions
vendor/bin/phpunit --filter WP_Test_WP_Job_Manager_Settingsvendor/bin/phpunitwp-admin/edit.php?post_type=job_listing&page=job-manager-settings#settings-general