Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape menu & post type labels #2630

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Escape menu & post type labels #2630

merged 3 commits into from
Nov 10, 2023

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Nov 7, 2023 •
edited by github-actions bot
Loading

Changes Proposed in this Pull Request

  • Make sure translatable submenu labels are escaped
  • Also escape post type labels as some of them are rendered raw by WP core

Testing Instructions

  • Navigate to the Job Manager menu and through the Job listing pages, make sure text is not broken

Release Notes

  • Fix: Escape menu titles and various admin labels
Plugin build for 0ad8bec
📦 Download plugin zip
▶️ Open in playground

Base automatically changed from tweak/check-plugin-version-upsell to feature/upsells November 7, 2023 16:47
Base automatically changed from feature/upsells to trunk November 9, 2023 15:48
@yscik yscik added this to the 2.0.0 milestone Nov 9, 2023
gikaragia
gikaragia approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@gikaragia gikaragia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yscik yscik merged commit f217580 into trunk Nov 10, 2023
8 checks passed
@yscik yscik deleted the change/escape-labels branch November 10, 2023 16:16
@gikaragia gikaragia mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gikaragia gikaragia gikaragia approved these changes

Assignees

@yscik yscik

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yscik @gikaragia