Trigger search when submitting search form #2457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2304
Changes proposed in this Pull Request
Testing instructions
Notes
There is a bit of trade-off here. The search so far triggers on
change
events, which occurs when unfocusing an input. And that happens when the users moves to click the submit button. So in most cases the search would happen anyway. And in fact, with this change, the search request is duplicated, because both the change event and the submit event triggers it.The code cancels the ongoing search request when a new one is issued, but in this case it might make more sense to only trigger the search on submit when it's not already going on?