Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8.2 deprecations #2456

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Fix PHP 8.2 deprecations #2456

merged 1 commit into from
Jun 19, 2023

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Jun 16, 2023

Fixes #2444

Changes proposed in this Pull Request

  • Fix dynamic property declarations that are deprecated in PHP 8.2

@yscik yscik requested a review from a team June 16, 2023 11:47
mikeyarce
mikeyarce approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@mikeyarce mikeyarce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@yscik yscik merged commit a09f7fa into trunk Jun 19, 2023
@yscik yscik deleted the fix/php-8.2 branch June 19, 2023 11:08
@yscik yscik linked an issue Jun 21, 2023 that may be closed by this pull request
Deprecated Messages for PHP 8.2 #2463
Closed
@yscik yscik mentioned this pull request Jun 21, 2023
Closed
@yscik yscik added this to the 1.41.0 milestone Jun 27, 2023
@gikaragia gikaragia changed the title Fix PHP 8.2 deprecations (Core) Fix PHP 8.2 deprecations Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeyarce mikeyarce mikeyarce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.

Deprecated Messages for PHP 8.2 PHP 8.2 issues (PHP Deprecated: Creation of dynamic property)
2 participants
@yscik @mikeyarce