Add check for job listing limit being 0

[mikeyarce]

Fixes #2333

Changes proposed in this Pull Request

• Add a check for job listing limit being 0. Currently if it's set to 0 it works the same as it being unlimited, which I don't think is intended.

Testing instructions

• Create a few job listings
• Set the limit to 0
• Verify that you can't add more job listings

[yscik]

Looks like this option is also used here where the same change should happen.

WP-Job-Manager/includes/class-wp-job-manager-shortcodes.php

Lines 110 to 114 in 7411e91

	if (
	$submit_job_form_page_id
	&& $submission_limit
	&& $job_count >= $submission_limit
	) {

And is there a similar check on the actual job submission page and endpoint?

[mikeyarce]

@yscik - I tried the logic you are suggesting but it won't work if the Listing Limit is 0.

The logic I have now is:

• Is this the job submit form page?
• AND ( Are we below the limit OR is there a submission limit in place?)

Use Cases

No Limit

• $submission_limit will be false
• job_manager_count_user_job_listings() < $submission_limit will be false

0 Limit

• $submission_limit will be false
• job_manager_count_user_job_listings() < $submission_limit will be false

So in both cases we have both false, however they need to work in the opposite way.

I thought about adding this

if ( '0' == get_option( 'job_manager_submission_limit' ) ) {
	$submission_limit = true;
}

But, it seemed cleaner to just have a false === $submission_limit check. What do you think?

[yscik]

empty(0) and empty('0') is also true. I think we need '' !== get_option( 'job_manager_submission_limit', '' ) to test if it doesn't have any value set.

The if below checks for 'false' (string) instead of the false (bool) set here.

[mikeyarce]

Fixed in a8d3b34

[yscik]

There are other places in the plugin where this check needs to be updated. Might make sense to add a new job_manager_can_user_submit_job() to handle it consistently everywhere.

WP-Job-Manager/includes/class-wp-job-manager-shortcodes.php

Lines 110 to 114 in 7411e91

	if (
	$submit_job_form_page_id
	&& $submission_limit
	&& $job_count >= $submission_limit
	) {

[mikeyarce]

@yscik Thanks for the suggestions! I made a helper function job_manager_user_can_submit_job_listing to address this. I also added the check into the shortcode in e7b5f42

[gikaragia]

Suggested a small improvement. Other than that it looks good!

[gikaragia]

You can set the $can_submit variable only once with:

	$can_submit = '' === $submission_limit || $submission_limit > $job_count;

[mikeyarce]

Thanks @gkaragia ! Done in cc64267

[gikaragia]

Looks good!