-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to send JS exceptions to Sentry #202
Conversation
47fe77b
to
57e6f1a
Compare
This is needed to make Sentry symbolicate the stack trace.
hi folks 👋 Just a heads-up that I recently bumped Sentry SDK to new major version #201 . Maybe we could sync this branch with |
Hey @wzieba 👋 , thanks for the heads up 🙇 ! Sure, we'll update with |
...acks/src/main/java/com/automattic/android/tracks/crashlogging/internal/SentryCrashLogging.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
Related Changes:
This PR expands the Crash logging service to support logging JavaScript exceptions to Sentry. This will allow hybrid sources like React Native (used in Gutenberg Mobile) to log exceptions with detailed information and symbolicated stack traces, which will greatly simplify the crash debugging process.
To test
Since it involves testing exceptions, we need to modify the code to force them and generate an installable build. A test PR has been created for this purpose, follow the testing instructions from wordpress-mobile/gutenberg-mobile#6654.