Use NS_RETURNS_RETAINED macro to save time (TextureGroup#843)

* Use NS_RETURNS_RETAINED macro to save time * Update changelog and do the thing with the license headers
AtomTickets · Apr 25, 2018 · e529ec2 · e529ec2
1 parent e8eba32
commit e529ec2
Show file tree

Hide file tree

Showing 61 changed files with 239 additions and 184 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -35,8 +35,9 @@
 - Fix UIResponder handling with view backing ASDisplayNode. [Michael Schneider](https://github.com/maicki) [#789](https://github.com/TextureGroup/Texture/pull/789/)
 - Optimized thread-local storage by replacing pthread_specific with C11 thread-local variables. [Adlai Holler](https://github.com/Adlai-Holler) [#811](https://github.com/TextureGroup/Texture/pull/811/)
 - Fixed a thread-sanitizer warning in ASTextNode. [Adlai Holler](https://github.com/Adlai-Holler) [#830](https://github.com/TextureGroup/Texture/pull/830/)
-- Fix ASTextNode2 handling background color incorrectly. [Adlai Holler](https://github.com/Adlai-Holler) [#831] (https://github.com/TextureGroup/Texture/pull/831/)
+- Fix ASTextNode2 handling background color incorrectly. [Adlai Holler](https://github.com/Adlai-Holler) [#831](https://github.com/TextureGroup/Texture/pull/831/)
 - [NoCopyRendering] Improved performance & fixed image memory not being tagged in Instruments. [Adlai Holler](https://github.com/Adlai-Holler) [#833](https://github.com/TextureGroup/Texture/pull/833/)
+- Use `NS_RETURNS_RETAINED` macro to make our methods a tiny bit faster. [Adlai Holler](https://github.com/Adlai-Holler) [#843](https://github.com/TextureGroup/Texture/pull/843/)
 
 ## 2.6
 - [Xcode 9] Updated to require Xcode 9 (to fix warnings) [Garrett Moon](https://github.com/garrettmoon)

diff --git a/Source/ASDisplayNode.mm b/Source/ASDisplayNode.mm
@@ -462,7 +462,7 @@ - (void)_scheduleIvarsForMainDeallocation
  *
  * Result is of type NSValue<[Ivar]>
  */
-+ (NSValue * _Nonnull)_ivarsThatMayNeedMainDeallocation
++ (NSValue * _Nonnull)_ivarsThatMayNeedMainDeallocation NS_RETURNS_RETAINED
 {
   static NSCache<Class, NSValue *> *ivarsCache;
   static dispatch_once_t onceToken;

diff --git a/Source/ASMapNode.mm b/Source/ASMapNode.mm
@@ -263,7 +263,7 @@ - (void)takeSnapshot
   }];
 }
 
-+ (UIImage *)defaultPinImageWithCenterOffset:(CGPoint *)centerOffset
++ (UIImage *)defaultPinImageWithCenterOffset:(CGPoint *)centerOffset NS_RETURNS_RETAINED
 {
   static MKAnnotationView *pin;
   static dispatch_once_t onceToken;

diff --git a/Source/ASMultiplexImageNode.h b/Source/ASMultiplexImageNode.h
@@ -270,7 +270,7 @@ didFinishDownloadingImageWithIdentifier:(ASImageIdentifier)imageIdentifier
 + (NSURL *)URLWithAssetLocalIdentifier:(NSString *)assetLocalIdentifier
                             targetSize:(CGSize)targetSize
                            contentMode:(PHImageContentMode)contentMode
-                               options:(PHImageRequestOptions *)options AS_WARN_UNUSED_RESULT API_AVAILABLE(ios(8.0), tvos(10.0));
+                               options:(PHImageRequestOptions *)options NS_RETURNS_RETAINED AS_WARN_UNUSED_RESULT API_AVAILABLE(ios(8.0), tvos(10.0));
 
 @end
 

diff --git a/Source/ASMultiplexImageNode.mm b/Source/ASMultiplexImageNode.mm
@@ -894,7 +894,7 @@ - (void)_finishedLoadingImage:(UIImage *)image forIdentifier:(id)imageIdentifier
 
 @implementation NSURL (ASPhotosFrameworkURLs)
 
-+ (NSURL *)URLWithAssetLocalIdentifier:(NSString *)assetLocalIdentifier targetSize:(CGSize)targetSize contentMode:(PHImageContentMode)contentMode options:(PHImageRequestOptions *)options
++ (NSURL *)URLWithAssetLocalIdentifier:(NSString *)assetLocalIdentifier targetSize:(CGSize)targetSize contentMode:(PHImageContentMode)contentMode options:(PHImageRequestOptions *)options NS_RETURNS_RETAINED
 {
   ASPhotosFrameworkImageRequest *request = [[ASPhotosFrameworkImageRequest alloc] initWithAssetIdentifier:assetLocalIdentifier];
   request.options = options;

diff --git a/Source/ASRunLoopQueue.h b/Source/ASRunLoopQueue.h
@@ -68,6 +68,7 @@ AS_SUBCLASSING_RESTRICTED
  * Each node will only be called once per transaction commit to reflect interface change.
  */
 @property (class, atomic, readonly) ASCATransactionQueue *sharedQueue;
++ (ASCATransactionQueue *)sharedQueue NS_RETURNS_RETAINED;
 
 - (void)enqueue:(id<ASCATransactionQueueObserving>)object;
 
@@ -83,6 +84,7 @@ AS_SUBCLASSING_RESTRICTED
 @interface ASDeallocQueue : NSObject
 
 @property (class, atomic, readonly) ASDeallocQueue *sharedDeallocationQueue;
++ (ASDeallocQueue *)sharedDeallocationQueue NS_RETURNS_RETAINED;
 
 - (void)test_drain;
 

diff --git a/Source/ASRunLoopQueue.mm b/Source/ASRunLoopQueue.mm
@@ -45,7 +45,7 @@ @implementation ASDeallocQueue {
   ASDN::RecursiveMutex _queueLock;
 }
 
-+ (ASDeallocQueue *)sharedDeallocationQueue
++ (ASDeallocQueue *)sharedDeallocationQueue NS_RETURNS_RETAINED
 {
   static ASDeallocQueue *deallocQueue = nil;
   static dispatch_once_t onceToken;
@@ -516,7 +516,7 @@ @implementation ASCATransactionQueue
 // and kASASCATransactionQueuePostOrder will apply interface change immediately.
 static int const kASASCATransactionQueuePostOrder = 3000000;
 
-+ (ASCATransactionQueue *)sharedQueue
++ (ASCATransactionQueue *)sharedQueue NS_RETURNS_RETAINED
 {
   static dispatch_once_t onceToken;
   static ASCATransactionQueue *sharedQueue;

diff --git a/Source/ASTextNode2.mm b/Source/ASTextNode2.mm
@@ -372,7 +372,7 @@ - (NSObject *)drawParametersForAsyncLayer:(_ASDisplayLayer *)layer
  * NOTE: Be careful to copy `text` if needed.
  */
 + (ASTextLayout *)compatibleLayoutWithContainer:(ASTextContainer *)container
-                                           text:(NSAttributedString *)text
+                                           text:(NSAttributedString *)text NS_RETURNS_RETAINED
 
 {
   // Allocate layoutCacheLock on the heap to prevent destruction at app exit (https://github.com/TextureGroup/Texture/issues/136)

diff --git a/Source/Debug/AsyncDisplayKit+Debug.m b/Source/Debug/AsyncDisplayKit+Debug.m
@@ -213,7 +213,7 @@ - (void)drawEdgeIfClippedWithEdges:(UIRectEdge)rectEdge color:(UIColor *)color b
 
 @interface _ASRangeDebugOverlayView : UIView
 
-+ (instancetype)sharedInstance;
++ (instancetype)sharedInstance NS_RETURNS_RETAINED;
 
 - (void)addRangeController:(ASRangeController *)rangeController;
 
@@ -311,7 +311,7 @@ + (UIWindow *)keyWindow
   return [[NSClassFromString(@"UIApplication") sharedApplication] keyWindow];
 }
 
-+ (instancetype)sharedInstance
++ (_ASRangeDebugOverlayView *)sharedInstance NS_RETURNS_RETAINED
 {
   static _ASRangeDebugOverlayView *__rangeDebugOverlay = nil;
 
@@ -752,7 +752,7 @@ - (ASImageNode *)createRangeNodeWithColor:(UIColor *)color
     return rangeBarImageNode;
 }
 
-+ (NSAttributedString *)whiteAttributedStringFromString:(NSString *)string withSize:(CGFloat)size
++ (NSAttributedString *)whiteAttributedStringFromString:(NSString *)string withSize:(CGFloat)size NS_RETURNS_RETAINED
 {
   NSDictionary *attributes = @{NSForegroundColorAttributeName : [UIColor whiteColor],
                                NSFontAttributeName            : [UIFont systemFontOfSize:size]};

diff --git a/Source/Details/ASBasicImageDownloader.h b/Source/Details/ASBasicImageDownloader.h
@@ -34,6 +34,7 @@ NS_ASSUME_NONNULL_BEGIN
  * @note It is strongly recommended you include PINRemoteImage and use @c ASPINRemoteImageDownloader instead.
  */
 @property (class, readonly) ASBasicImageDownloader *sharedImageDownloader;
++ (ASBasicImageDownloader *)sharedImageDownloader NS_RETURNS_RETAINED;
 
 + (instancetype)new __attribute__((unavailable("+[ASBasicImageDownloader sharedImageDownloader] must be used.")));
 - (instancetype)init __attribute__((unavailable("+[ASBasicImageDownloader sharedImageDownloader] must be used.")));

diff --git a/Source/Details/ASIntegerMap.h b/Source/Details/ASIntegerMap.h
@@ -29,21 +29,23 @@ AS_SUBCLASSING_RESTRICTED
  */
 + (ASIntegerMap *)mapForUpdateWithOldCount:(NSInteger)oldCount
                                    deleted:(nullable NSIndexSet *)deleted
-                                  inserted:(nullable NSIndexSet *)inserted;
+                                  inserted:(nullable NSIndexSet *)inserted NS_RETURNS_RETAINED;
 
 /**
  * A singleton that maps each integer to itself. Its inverse is itself.
  *
  * Note: You cannot mutate this.
  */
 @property (class, atomic, readonly) ASIntegerMap *identityMap;
++ (ASIntegerMap *)identityMap NS_RETURNS_RETAINED;
 
 /**
  * A singleton that returns NSNotFound for all keys. Its inverse is itself.
  *
  * Note: You cannot mutate this.
  */
 @property (class, atomic, readonly) ASIntegerMap *emptyMap;
++ (ASIntegerMap *)emptyMap NS_RETURNS_RETAINED;
 
 /**
  * Retrieves the integer for a given key, or NSNotFound if the key is not found.

diff --git a/Source/Details/ASIntegerMap.mm b/Source/Details/ASIntegerMap.mm
@@ -31,7 +31,7 @@ @implementation ASIntegerMap {
 
 #pragma mark - Singleton
 
-+ (ASIntegerMap *)identityMap
++ (ASIntegerMap *)identityMap NS_RETURNS_RETAINED
 {
   static ASIntegerMap *identityMap;
   static dispatch_once_t onceToken;
@@ -43,7 +43,7 @@ + (ASIntegerMap *)identityMap
   return identityMap;
 }
 
-+ (ASIntegerMap *)emptyMap
++ (ASIntegerMap *)emptyMap NS_RETURNS_RETAINED
 {
   static ASIntegerMap *emptyMap;
   static dispatch_once_t onceToken;
@@ -55,7 +55,7 @@ + (ASIntegerMap *)emptyMap
   return emptyMap;
 }
 
-+ (ASIntegerMap *)mapForUpdateWithOldCount:(NSInteger)oldCount deleted:(NSIndexSet *)deletions inserted:(NSIndexSet *)insertions
++ (ASIntegerMap *)mapForUpdateWithOldCount:(NSInteger)oldCount deleted:(NSIndexSet *)deletions inserted:(NSIndexSet *)insertions NS_RETURNS_RETAINED
 {
   if (oldCount == 0) {
     return ASIntegerMap.emptyMap;

diff --git a/Source/Details/ASPINRemoteImageDownloader.h b/Source/Details/ASPINRemoteImageDownloader.h
@@ -35,6 +35,7 @@ NS_ASSUME_NONNULL_BEGIN
  * available. It uses PINRemoteImage's features to provide caching and progressive image downloads.
  */
 @property (class, readonly) ASPINRemoteImageDownloader *sharedDownloader;
++ (ASPINRemoteImageDownloader *)sharedDownloader NS_RETURNS_RETAINED;
 
 
 /**

diff --git a/Source/Details/ASPINRemoteImageDownloader.m b/Source/Details/ASPINRemoteImageDownloader.m
@@ -114,7 +114,7 @@ @interface ASPINRemoteImageDownloader ()
 
 @implementation ASPINRemoteImageDownloader
 
-+ (ASPINRemoteImageDownloader *)sharedDownloader
++ (ASPINRemoteImageDownloader *)sharedDownloader NS_RETURNS_RETAINED
 {
 
   static dispatch_once_t onceToken = 0;

diff --git a/Source/Details/ASPageTable.h b/Source/Details/ASPageTable.h
@@ -82,12 +82,12 @@ typedef ASPageTable<id, NSMutableArray<UICollectionViewLayoutAttributes *> *> AS
 /**
  * Creates a new page table with (NSMapTableStrongMemory | NSMapTableObjectPointerPersonality) for values.
  */
-+ (ASPageTable *)pageTableForStrongObjectPointers;
++ (ASPageTable *)pageTableForStrongObjectPointers NS_RETURNS_RETAINED;
 
 /**
  * Creates a new page table with (NSMapTableWeakMemory | NSMapTableObjectPointerPersonality) for values.
  */
-+ (ASPageTable *)pageTableForWeakObjectPointers;
++ (ASPageTable *)pageTableForWeakObjectPointers NS_RETURNS_RETAINED;
 
 /**
  * Builds a new page to layout attributes from the given layout attributes.
@@ -98,7 +98,7 @@ typedef ASPageTable<id, NSMutableArray<UICollectionViewLayoutAttributes *> *> AS
  *
  * @param pageSize The size of each page.
  */
-+ (ASPageToLayoutAttributesTable *)pageTableWithLayoutAttributes:(id<NSFastEnumeration>)layoutAttributesEnumerator contentSize:(CGSize)contentSize pageSize:(CGSize)pageSize;
++ (ASPageToLayoutAttributesTable *)pageTableWithLayoutAttributes:(id<NSFastEnumeration>)layoutAttributesEnumerator contentSize:(CGSize)contentSize pageSize:(CGSize)pageSize NS_RETURNS_RETAINED;
 
 /**
  * Retrieves the object for a given page, or nil if the page is not found.

diff --git a/Source/Details/ASPageTable.m b/Source/Details/ASPageTable.m
@@ -79,7 +79,7 @@ extern CGRect ASPageCoordinateGetPageRect(ASPageCoordinate pageCoordinate, CGSiz
 
 @implementation NSMapTable (ASPageTableMethods)
 
-+ (instancetype)pageTableWithValuePointerFunctions:(NSPointerFunctions *)valueFuncs
++ (instancetype)pageTableWithValuePointerFunctions:(NSPointerFunctions *)valueFuncs NS_RETURNS_RETAINED
 {
   static NSPointerFunctions *pageCoordinatesFuncs;
   static dispatch_once_t onceToken;
@@ -90,7 +90,7 @@ + (instancetype)pageTableWithValuePointerFunctions:(NSPointerFunctions *)valueFu
   return [[NSMapTable alloc] initWithKeyPointerFunctions:pageCoordinatesFuncs valuePointerFunctions:valueFuncs capacity:0];
 }
 
-+ (ASPageTable *)pageTableForStrongObjectPointers
++ (ASPageTable *)pageTableForStrongObjectPointers NS_RETURNS_RETAINED
 {
   static NSPointerFunctions *strongObjectPointerFuncs;
   static dispatch_once_t onceToken;
@@ -100,7 +100,7 @@ + (ASPageTable *)pageTableForStrongObjectPointers
   return [self pageTableWithValuePointerFunctions:strongObjectPointerFuncs];
 }
 
-+ (ASPageTable *)pageTableForWeakObjectPointers
++ (ASPageTable *)pageTableForWeakObjectPointers NS_RETURNS_RETAINED
 {
   static NSPointerFunctions *weakObjectPointerFuncs;
   static dispatch_once_t onceToken;
@@ -110,7 +110,7 @@ + (ASPageTable *)pageTableForWeakObjectPointers
   return [self pageTableWithValuePointerFunctions:weakObjectPointerFuncs];
 }
 
-+ (ASPageToLayoutAttributesTable *)pageTableWithLayoutAttributes:(id<NSFastEnumeration>)layoutAttributesEnumerator contentSize:(CGSize)contentSize pageSize:(CGSize)pageSize
++ (ASPageToLayoutAttributesTable *)pageTableWithLayoutAttributes:(id<NSFastEnumeration>)layoutAttributesEnumerator contentSize:(CGSize)contentSize pageSize:(CGSize)pageSize NS_RETURNS_RETAINED
 {
   ASPageToLayoutAttributesTable *result = [ASPageTable pageTableForStrongObjectPointers];
   for (UICollectionViewLayoutAttributes *attrs in layoutAttributesEnumerator) {

diff --git a/Source/Details/ASTraitCollection.h b/Source/Details/ASTraitCollection.h
@@ -194,11 +194,11 @@ AS_SUBCLASSING_RESTRICTED
 @property (nonatomic, assign, readonly) CGSize containerSize;
 
 + (ASTraitCollection *)traitCollectionWithUITraitCollection:(UITraitCollection *)traitCollection
-                                              containerSize:(CGSize)windowSize;
+                                              containerSize:(CGSize)windowSize NS_RETURNS_RETAINED;
 
 + (ASTraitCollection *)traitCollectionWithUITraitCollection:(UITraitCollection *)traitCollection
                                               containerSize:(CGSize)windowSize
-                                fallbackContentSizeCategory:(UIContentSizeCategory)fallbackContentSizeCategory;
+                                fallbackContentSizeCategory:(UIContentSizeCategory)fallbackContentSizeCategory NS_RETURNS_RETAINED;
 
 #if TARGET_OS_TV
 + (ASTraitCollection *)traitCollectionWithHorizontalSizeClass:(UIUserInterfaceSizeClass)horizontalSizeClass
@@ -210,7 +210,7 @@ AS_SUBCLASSING_RESTRICTED
                                               layoutDirection:(UITraitEnvironmentLayoutDirection)layoutDirection
                                            userInterfaceStyle:(UIUserInterfaceStyle)userInterfaceStyle
                                  preferredContentSizeCategory:(UIContentSizeCategory)preferredContentSizeCategory
-                                                containerSize:(CGSize)windowSize;
+                                                containerSize:(CGSize)windowSize NS_RETURNS_RETAINED;
 #else
 + (ASTraitCollection *)traitCollectionWithHorizontalSizeClass:(UIUserInterfaceSizeClass)horizontalSizeClass
                                             verticalSizeClass:(UIUserInterfaceSizeClass)verticalSizeClass
@@ -220,7 +220,7 @@ AS_SUBCLASSING_RESTRICTED
                                          forceTouchCapability:(UIForceTouchCapability)forceTouchCapability
                                               layoutDirection:(UITraitEnvironmentLayoutDirection)layoutDirection
                                  preferredContentSizeCategory:(UIContentSizeCategory)preferredContentSizeCategory
-                                                containerSize:(CGSize)windowSize;
+                                                containerSize:(CGSize)windowSize NS_RETURNS_RETAINED;
 #endif
 
 - (BOOL)isEqualToTraitCollection:(ASTraitCollection *)traitCollection;
@@ -232,7 +232,7 @@ AS_SUBCLASSING_RESTRICTED
  */
 @interface ASTraitCollection (PrimitiveTraits)
 
-+ (ASTraitCollection *)traitCollectionWithASPrimitiveTraitCollection:(ASPrimitiveTraitCollection)traits;
++ (ASTraitCollection *)traitCollectionWithASPrimitiveTraitCollection:(ASPrimitiveTraitCollection)traits NS_RETURNS_RETAINED;
 
 - (ASPrimitiveTraitCollection)primitiveTraitCollection;
 
@@ -248,7 +248,7 @@ AS_SUBCLASSING_RESTRICTED
                                      verticalSizeClass:(UIUserInterfaceSizeClass)verticalSizeClass
                                   forceTouchCapability:(UIForceTouchCapability)forceTouchCapability
                                          containerSize:(CGSize)windowSize
-  ASDISPLAYNODE_DEPRECATED_MSG("Use full version of this method instead.");
+  NS_RETURNS_RETAINED ASDISPLAYNODE_DEPRECATED_MSG("Use full version of this method instead.");
 
 @end
 

diff --git a/Source/Details/ASTraitCollection.m b/Source/Details/ASTraitCollection.m
@@ -283,7 +283,7 @@ + (instancetype)traitCollectionWithHorizontalSizeClass:(UIUserInterfaceSizeClass
                                        layoutDirection:(UITraitEnvironmentLayoutDirection)layoutDirection
                                     userInterfaceStyle:(UIUserInterfaceStyle)userInterfaceStyle
                           preferredContentSizeCategory:(UIContentSizeCategory _Nonnull)preferredContentSizeCategory
-                                         containerSize:(CGSize)windowSize
+                                         containerSize:(CGSize)windowSize NS_RETURNS_RETAINED
 {
   return [[self alloc] initWithHorizontalSizeClass:horizontalSizeClass
                                  verticalSizeClass:verticalSizeClass
@@ -332,7 +332,7 @@ + (instancetype)traitCollectionWithHorizontalSizeClass:(UIUserInterfaceSizeClass
                                   forceTouchCapability:(UIForceTouchCapability)forceTouchCapability
                                        layoutDirection:(UITraitEnvironmentLayoutDirection)layoutDirection
                           preferredContentSizeCategory:(UIContentSizeCategory _Nonnull)preferredContentSizeCategory
-                                         containerSize:(CGSize)windowSize
+                                         containerSize:(CGSize)windowSize NS_RETURNS_RETAINED
 {
   return [[self alloc] initWithHorizontalSizeClass:horizontalSizeClass
                                  verticalSizeClass:verticalSizeClass
@@ -348,7 +348,7 @@ + (instancetype)traitCollectionWithHorizontalSizeClass:(UIUserInterfaceSizeClass
 #endif
 
 + (instancetype)traitCollectionWithUITraitCollection:(UITraitCollection *)traitCollection
-                                       containerSize:(CGSize)windowSize
+                                       containerSize:(CGSize)windowSize NS_RETURNS_RETAINED
 {
   return [self traitCollectionWithUITraitCollection:traitCollection
                                       containerSize:windowSize
@@ -358,7 +358,7 @@ + (instancetype)traitCollectionWithUITraitCollection:(UITraitCollection *)traitC
 
 + (instancetype)traitCollectionWithUITraitCollection:(UITraitCollection *)traitCollection
                                        containerSize:(CGSize)windowSize
-                         fallbackContentSizeCategory:(UIContentSizeCategory _Nonnull)fallbackContentSizeCategory
+                         fallbackContentSizeCategory:(UIContentSizeCategory _Nonnull)fallbackContentSizeCategory NS_RETURNS_RETAINED
 {
   UIDisplayGamut displayGamut;
   UITraitEnvironmentLayoutDirection layoutDirection;
@@ -435,7 +435,7 @@ - (BOOL)isEqualToTraitCollection:(ASTraitCollection *)traitCollection
 
 @implementation ASTraitCollection (PrimitiveTraits)
 
-+ (instancetype)traitCollectionWithASPrimitiveTraitCollection:(ASPrimitiveTraitCollection)traits
++ (instancetype)traitCollectionWithASPrimitiveTraitCollection:(ASPrimitiveTraitCollection)traits NS_RETURNS_RETAINED
 {
 #if TARGET_OS_TV
   return [self traitCollectionWithHorizontalSizeClass:traits.horizontalSizeClass
@@ -514,7 +514,7 @@ + (ASTraitCollection *)traitCollectionWithDisplayScale:(CGFloat)displayScale
                                    horizontalSizeClass:(UIUserInterfaceSizeClass)horizontalSizeClass
                                      verticalSizeClass:(UIUserInterfaceSizeClass)verticalSizeClass
                                   forceTouchCapability:(UIForceTouchCapability)forceTouchCapability
-                                         containerSize:(CGSize)windowSize
+                                         containerSize:(CGSize)windowSize NS_RETURNS_RETAINED
 {
 #if TARGET_OS_TV
   return [self traitCollectionWithHorizontalSizeClass:horizontalSizeClass

diff --git a/Source/Details/ASWeakProxy.h b/Source/Details/ASWeakProxy.h
@@ -35,6 +35,6 @@ AS_SUBCLASSING_RESTRICTED
  *
  * @return an instance of ASWeakProxy
  */
-+ (instancetype)weakProxyWithTarget:(id)target;
++ (instancetype)weakProxyWithTarget:(id)target NS_RETURNS_RETAINED;
 
 @end
diff --git a/Source/Details/ASWeakProxy.m b/Source/Details/ASWeakProxy.m
@@ -29,7 +29,7 @@ - (instancetype)initWithTarget:(id)target
   return self;
 }
 
-+ (instancetype)weakProxyWithTarget:(id)target
++ (instancetype)weakProxyWithTarget:(id)target NS_RETURNS_RETAINED
 {
   return [[ASWeakProxy alloc] initWithTarget:target];
 }