Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update with feedback #28

Merged
merged 7 commits into from
Jul 5, 2023
Merged

fix: update with feedback #28

merged 7 commits into from
Jul 5, 2023

Conversation

tiendn
Copy link
Collaborator

@tiendn tiendn commented Jul 5, 2023 •
edited
Loading

Screen Shot 2023-07-05 at 16 52 51
Screen Shot 2023-07-05 at 16 53 02
Screen Shot 2023-07-05 at 16 53 33
Screen Shot 2023-07-05 at 16 54 47

@tiendn tiendn requested a review from ruitran as a code owner July 5, 2023 09:52
ruitran
ruitran approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@ruitran ruitran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiendn tiendn merged commit 1987324 into dev Jul 5, 2023
3 of 5 checks passed
@tiendn tiendn deleted the fix/update-with-feedback branch July 5, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruitran ruitran ruitran approved these changes

@viennguyen2-tiki viennguyen2-tiki viennguyen2-tiki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiendn @ruitran @viennguyen2-tiki