fix: transaction not found on blockscout (#4)

* fix: transaction not found on blockscout

* refactor: remove duplicate code

infrastructure/blockscout/httpclient.go

@@ -16,6 +16,7 @@ import (
 )
 
 const GET_DETAIL_EVM_TX = "/api/v1?module=transaction&action=getTxCosmosInfo&txhash="
+const TX_NOT_FOUND = "transaction not found"
 
 type HTTPClient struct {
 	httpClient *retryablehttp.Client
@@ -123,5 +124,10 @@ func (client *HTTPClient) GetDetailEvmTx(txHash string) (*TransactionEvm, error)
 	if err := jsoniter.NewDecoder(rawRespBody).Decode(&txResp); err != nil {
 		return nil, err
 	}
+
+	if txResp.Status == "0" {
+		return nil, fmt.Errorf(TX_NOT_FOUND)
+	}
+
 	return &txResp.Result, nil
 }

infrastructure/httpapi/handlers/transactions.go

@@ -2,6 +2,8 @@ package handlers
 
 import (
 	"errors"
+	"fmt"
+	"strings"
 	"time"
 
 	"github.com/AstraProtocol/astra-indexing/appinterface/pagination"
@@ -59,9 +61,15 @@ func (handler *Transactions) FindByHash(ctx *fasthttp.RequestCtx) {
 	if string(ctx.QueryArgs().Peek("type")) == "evm" {
 		transaction, err := handler.blockscoutClient.GetDetailEvmTx(hashParam)
 		if err != nil {
-			handler.logger.Errorf("error parsing tx response from blockscout: %v", err)
-			httpapi.InternalServerError(ctx)
-			return
+			if strings.Contains(fmt.Sprint(err), blockscout_infrastructure.TX_NOT_FOUND) {
+				ctx.QueryArgs().Del("type")
+				handler.FindByHash(ctx)
+				return
+			} else {
+				handler.logger.Errorf("error parsing tx response from blockscout: %v", err)
+				httpapi.InternalServerError(ctx)
+				return
+			}
 		}
 		httpapi.Success(ctx, transaction)
 	} else {