Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix evm tracing for older runtimes #1307

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented Jul 24, 2024

Pull Request Summary

Fix EVM tracing for older runtimes.
paritytech/polkadot-sdk#1781 updated initialize_block to return ExtrinsicInclusionMode so for old runtimes we need to call older initialize_block_before_version_5

@ermalkaleci ermalkaleci added the client This PR/Issue is related to the topic “client”. label Jul 24, 2024
@ermalkaleci ermalkaleci marked this pull request as ready for review July 24, 2024 21:48
@ermalkaleci ermalkaleci linked an issue Jul 24, 2024 that may be closed by this pull request
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/dapp-staking-v3/src 90% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/ethereum-checked/src 79% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/static-price-provider/src 52% 0%
precompiles/dispatch-lockdrop/src 86% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
primitives/src 62% 0%
primitives/src/xcm 65% 0%
pallets/unified-accounts/src 77% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
pallets/xc-asset-config/src 50% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/collator-selection/src 92% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/xvm/src 54% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
pallets/price-aggregator/src 75% 0%
chain-extensions/types/xvm/src 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/collective-proxy/src 86% 0%
precompiles/xcm/src 71% 0%
pallets/dapp-staking-migration/src 0% 0%
precompiles/xvm/src 73% 0%
precompiles/unified-accounts/src 100% 0%
chain-extensions/xvm/src 0% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
precompiles/sr25519/src 64% 0%
precompiles/assets-erc20/src 78% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/inflation/src 86% 0%
Summary 76% (3706 / 4850) 0% (0 / 0)

Minimum allowed line rate is 50%

@ermalkaleci ermalkaleci merged commit 2280899 into master Jul 25, 2024
10 of 11 checks passed
@ermalkaleci ermalkaleci deleted the fix/evm-tracing-old-runtimes branch July 25, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client This PR/Issue is related to the topic “client”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing methods fail for certain blocks.
2 participants