Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove XVM pallet code #1303

Merged
merged 3 commits into from
Aug 1, 2024
Merged

refactor: remove XVM pallet code #1303

merged 3 commits into from
Aug 1, 2024

Conversation

ipapandinas
Copy link
Contributor

@ipapandinas ipapandinas commented Jul 17, 2024

Pull Request Summary

XVM pallet code is removed from the codebase and Shibuya runtime. Since the pallet and the precompile don't write to storage independently, there's no Shibuya on-chain storage to clean up.

Here is the documentation clean up related PR: AstarNetwork/astar-docs#692

Closes #1299

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.

@ipapandinas ipapandinas added shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Jul 17, 2024
Copy link
Contributor

@ermalkaleci ermalkaleci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing Ermal's comments

I'd also suggest to announce this somehow.
Maybe G' can help via builder's announcements.

Dinonard
Dinonard previously approved these changes Jul 19, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/types/assets/src 0% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/price-aggregator/src 75% 0%
precompiles/unified-accounts/src 100% 0%
pallets/dapp-staking-migration/src 0% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dapp-staking-v3/src/test 0% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/static-price-provider/src 52% 0%
pallets/inflation/src 86% 0%
primitives/src 60% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/xc-asset-config/src 50% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/sr25519/src 64% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/ethereum-checked/src 74% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
pallets/unified-accounts/src 77% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/dapp-staking-v3/src 90% 0%
pallets/collective-proxy/src 86% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
precompiles/assets-erc20/src 78% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
primitives/src/xcm 65% 0%
pallets/collator-selection/src 92% 0%
precompiles/xcm/src 71% 0%
Summary 78% (3581 / 4570) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard
Copy link
Member

@ermalkaleci can you approve if request for change was fulfilled?

@ermalkaleci
Copy link
Contributor

@Dinonard @ipapandinas I guess we can merge this

@Dinonard
Copy link
Member

Dinonard commented Aug 1, 2024

@Dinonard @ipapandinas I guess we can merge this

I'm waiting for @ipapandinas to merge his first PR into this repo as a member xD

@ipapandinas ipapandinas merged commit 7e31308 into master Aug 1, 2024
8 checks passed
@ipapandinas ipapandinas deleted the refactor/remove-xvm branch August 1, 2024 13:02
@ipapandinas
Copy link
Contributor Author

🎉 🥳 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deprecation] Remove XVM related code
3 participants