fix upgrade e2e test #1269
fix upgrade e2e test #1269
Conversation
ermalkaleci
added
ci
Minimum allowed line rate is |
| // wait a bit for pjs/api to update | ||
| await new Promise((r) => setTimeout(r, 1000)); |
There was a problem hiding this comment.
How come this is needed if you await for the block production above?
Doesn't it mean the newBlock function returns prematurely?
There was a problem hiding this comment.
It's not for block production but for ApiPromise to become aware of the new block and storage changes.
There was a problem hiding this comment.
Alice is sending both tx and some how it needed a bit of time to sync nonce
There was a problem hiding this comment.
Just to check if I understand correctly - remark is executed, followed by setCode, two new blocks are produced, then we wait for the internal chopsticks state to stabilize/sync, before proceeding forward?
I don't know how chopsticks works internally, but should it return from the newBlock if state isn't synced yet? Maybe it's a dumb question 🤷
There was a problem hiding this comment.
once block is build it will resolve and announce storage changes async for listeners (like ApiPromise). But because we're immediately creating a new tx (aslo because everything is running on a single js thread event loop) nextNounce may not be reflected immediately so second tx was build with old nonce resulting in invalid tx.
There was a problem hiding this comment.
even a 200ms will be enough but I added 1sec to be sure
There was a problem hiding this comment.
This appears to happen only when we perform an upgrade, this is making me think why 🤔, need to debug it
There was a problem hiding this comment.
@Dinonard Initially I thought it was sending old nonce but it's not nonce, it's spec_version. When runtime upgrades happen, it takes a few millis for ApiPromise to receive metadata from chopsticks (because it extracts it from runtime itself, runtime call needs to happen) but pjs/api doesn't wait for the new metadata but instead uses what it has (old spec_version) and making an invalid tx
Pull Request Summary
Update to latest chopsticks and bump deps