Add missing id attribute to editor's textarea
#359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, it is impossible to add custom config to a single CKEditor instance since `CKEDITOR.replace()` uses the `id` of the field, not the name. Signed-off-by: Micheal Mand <micheal@kmdwebdesigns.com>
|
Tanks! But for the translatable one, shouldn't the id match the |
|
You are correct. I will get that fixed. As an aside, I was under the impression that brackets ( |
Signed-off-by: Micheal Mand <micheal@kmdwebdesigns.com>
nWidart
added a commit
that referenced
this pull request
Sep 2, 2017
* 2.0: (81 commits) Make PHP < 7 happy Immediately call closure after binding Bind current object to the dynamic relations closure Fixing @return types Adding logout and loginUsingId methods on the sentinal guard Adding changelog item Removing obsolete files Abstract csv download inside Response macro Make TranslationController slim Move AsgardCms class to the foundation namespace Read core module version from the AsgardCms class other modules keep same logic. Removing the version number in composer.json Added an AsgardCms class containing the current cms version Always load migrations Preparing 2.5.2 release Fixing CLI issue not having the translation repository bound Preparing 2.5.1 release Adding changelog item Add missing `id` attribute to editor's textarea (#359) Renaming hook ContentIsRendering to PageContentIsRendering ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, it is impossible to add custom config to a single CKEditor instance since
CKEDITOR.replace()uses theidof the field, not the name.