Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu Module] Request for 'typicms/nestablecollection' version update #485

Closed
darron1217 opened this issue Mar 8, 2018 · 1 comment
Closed

[Menu Module] Request for 'typicms/nestablecollection' version update #485

darron1217 opened this issue Mar 8, 2018 · 1 comment

Comments

@darron1217
Copy link
Contributor

darron1217 commented Mar 8, 2018 •
edited
Loading

Summary of issue

Platform/Modules/Menu/composer.json

Line 28 in 9f9c4c4

"typicms/nestablecollection": "1.1.1"

On the menu module, typicms/nestablecollection version specified to 1.1.1 while the newest version is 1.1.8
I use the package typicms/nestablecollection on the other module, too.
So this constraint issue must be resolved to update the package (I can't use ->setIndent('> ') on listsFlattened() because of this issue...)

Q. How about changing version constraint from 1.1.1 to 1.1 ? (there was no conflict, I tested it)

Steps to reproduce

System Details

  • Operating System
  • PHP Version
  • Laravel Version
  • Asgardcms/Platform version
@darron1217 darron1217 mentioned this issue Mar 8, 2018
Merged
@darron1217
Copy link
Contributor Author

👍

nWidart pushed a commit that referenced this issue Jun 29, 2018
@darron1217 @nWidart
Solving issue #485
465de4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@darron1217