Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in ThemeManager Test for Theme backend edition #451

Closed
flixart33 opened this issue Jan 4, 2018 · 2 comments
Closed

Problem in ThemeManager Test for Theme backend edition #451

flixart33 opened this issue Jan 4, 2018 · 2 comments

Comments

@flixart33
Copy link

flixart33 commented Jan 4, 2018

Summary of issue

In Modules\Workshop\Manager\StylistThemeManager.php - line 45

foreach ($this->getDirectories() as $directory) { if (! str_contains(strtolower($directory), strtolower($themeName))) { continue; } return $this->getThemeInfoForPath($directory); }

This is too generalist, if le path of project include the theme name, all directories of themes will contain the theme name and first theme will be returned

Can you test only last member of path ?

Steps to reproduce

Create a theme in a path with the theme name.
Sample : /home/www/society-fr/web/Themes/Society

@zoltiecodes
Copy link
Contributor

+1
Thanks I was wasting an hour figuring out what causes the problem.

zoltiecodes added a commit to zoltiecodes/Platform that referenced this issue Feb 2, 2018
nWidart added a commit that referenced this issue Feb 26, 2018
@nWidart
Copy link
Member

nWidart commented Feb 26, 2018

Fixed and tagged in 3.5.1 🚀

@nWidart nWidart closed this as completed Feb 26, 2018
nWidart pushed a commit that referenced this issue Jun 29, 2018
Fix Issue #451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants