Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spanish translation for pretty much all the strings #445

Merged
merged 2 commits into from
Jan 20, 2019
Merged

Add Spanish translation for pretty much all the strings #445

merged 2 commits into from
Jan 20, 2019

Conversation

corp-0
Copy link
Contributor

@corp-0 corp-0 commented Jan 11, 2019

When merged this pull request will:

  • Add Spanish translation for pretty much all the strings in the Stringtable file.

The only strings that are not translated are the ones that would use the original string anyways.

@CreepPork CreepPork added feature PR that adds a new feature to Achilles. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time. labels Jan 11, 2019
@CreepPork CreepPork added this to the 1.3.0 milestone Jan 11, 2019
@Kexanone Kexanone removed their request for review January 11, 2019 17:12
@Kexanone
Copy link
Member

Thx for the translations. I resolved the merge conflicts.

@Kexanone Kexanone merged commit 874d4e8 into ArmaAchilles:master Jan 20, 2019
Kexanone added a commit that referenced this pull request Jan 20, 2019
@Kexanone
Revert "Add Spanish translation for pretty much all the strings (#445)"
7472f23 
This reverts commit 874d4e8.
@Kexanone Kexanone mentioned this pull request Jan 20, 2019
Merged
Kexanone added a commit that referenced this pull request Jan 21, 2019
@Kexanone
Revert "Add Spanish translation for pretty much all the strings (#445)"
6a31ef1 
This reverts commit 874d4e8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilzar neilzar neilzar approved these changes

@CreepPork CreepPork Awaiting requested review from CreepPork

Assignees

@corp-0 corp-0

Labels
feature PR that adds a new feature to Achilles. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@corp-0 @Kexanone @neilzar @CreepPork