Migrate to v4 API #91
Conversation
paulerickson
force-pushed
the
master
branch
3 times, most recently
from
db822ed
to
36c366b
Compare
|
@Argelbargel : this is working for me and I think @tuxx, so it would be super if you could take a look over when you can and see if is mergeworthy. |
|
Would love to see this its necessary since the gitlab 11 release. |
|
@paulerickson there looks to be issues with the It places in a ref: https://docs.gitlab.com/ee/api/v3_to_v4.html and https://docs.gitlab.com/ee/api/projects.html
|
|
Tested with Jenkins ver. 2.121.3. Had to literally add all classes in hudson.remoting.ClassFilter file for it to work (including some subclasses), but afterwards it started working. |
|
@imduffy15 @alexsirbu Is there a PR or a commit with your changes? The original commit by @paulerickson doesn't really work, possibly due to the issues that you two have mentioned, but I suspect there might be more things that need fixing after I do what you two have already mentioned. |
|
@Sumit-Ahuja pushed mine to here https://github.com/imduffy15/gitlab-branch-source-plugin |
|
As I haven't really worked on this before, my solution of adding all the classes and some subclasses (the ones I saw in errors in various places) might not be the best solution for solving the issue (went with the temporary solution from here - https://jenkins.io/blog/2018/01/13/jep-200/). However, this is unrelated directly with this issue of moving to V4 as it's related to Jenkins version compatibility - and there are separate issues for it already. |
|
@Argelbargel Do you have an opinion regarding @alexsirbu's solution? |
I will try it out, thanks. Had a similar solution for the membership and owned things. |
|
Do you have the "Don't trigger WIP Merge Request" feature working ? The filter seems to not be called in my local dev environnment. |
| StringBuilder urlBuilder = new StringBuilder(GitlabProject.URL).append("?membership=true"); | ||
| if (!VISIBLE.equals(selector)) { | ||
| urlBuilder.append("&").append(selector.id()).append("=true"); | ||
| } |
There was a problem hiding this comment.
@imduffy15 I pulled your changes and I think the reason I didn't have the issue you experienced is that I'm filtering on a group and maybe hitting the above projectUrl method and not this one. I'm assuming this block was in there for the same fix, so I replaced your two conditionals with this one for consistency. Does this look right to you?
|
@jbomaileva I haven't tested that myself, since I like building my PRs, but maybe someone else can weigh in. FWIW, I use this beauty when I want to be selective of // All PRs go to test
stage('Deploy PR to Test') {
when { changeRequest() }
steps {…}
}
// Only non-WIP PRs go to beta
stage('Deploy PR to Beta') {
when { allOf {
changeRequest()
expression { env.gitlabMergeRequestTitle ==~ /^(?i)(?!\[?WIP).*$/ } // Skip Work-In-Process PRs
} }
steps {…}
} |
|
@Argelbargel any chance of merging this? I have been using this build in production since August without incident and folks are making changes against this now for lack of v4 stuff on master. Thanks! |
|
Is there any fork/brach where we can use option Auto-Register Webhook |
|
@makarek that's working fine for me with this branch |
|
@paulerickson |
|
@makarek I get the same. Sorry, I don't know how to change it. |
|
@paulerickson @Argelbargel what is stopping this from being merged and released? |
|
Hi there, sorry for the long wait, but i've been quite busy with other things lately. |
See #80 — I took Ilya's changeset, removed in-progress Note stuff, tidied whitespace and rebased on upstream/master