Tools/environment_install: ensure venv is installed on all Ubuntus #28198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects missing 22.04 Jammy case and avoids need for hardcoded table.
khancyr
suggested changes
Sep 23, 2024
There was a problem hiding this comment.
doesn't work. It enable venv on focal: see https://github.com/ArduPilot/ardupilot/actions/runs/10983477074/job/30492890484
We got some autotest for that use the install scripts . If you are used to Docker that is quite simple to test those changes
|
Not sure why we want venv now on jammy ? |
|
Why would a venv only be desired on some versions? CI passes on all of them? I think the motivation is that ESP-IDF needs venv. |
|
Discussed briefly on the devcall and the consensus was that changing this is not desired. We will come up with an ESP32 specific solution if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects missing 22.04 Jammy case and avoids need for hardcoded table. Split out from #28080 .
Totally untested but seems right...