Fix double reloading on addStatModifier (#287)

Archy-X · May 31, 2024 · 2269daa · 2269daa
1 parent 08f5d27
commit 2269daa
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/common/src/main/java/dev/aurelium/auraskills/common/user/User.java b/common/src/main/java/dev/aurelium/auraskills/common/user/User.java
@@ -265,7 +265,10 @@ private <T extends AuraSkillsModifier<V>, V> void addModifier(T modifier, boolea
             if (oldModifier.type() == modifier.type() && oldModifier.value() == modifier.value()) {
                 return;
             }
-            removeModifier(modifier.name(), reload, map, levels);
+            // Do not reload on remove since that would reset health and other stuff (mainly for 3rd party plugins)
+            // Reload will happen at the end of this method if it was true either way.
+            // So here we are just preventing double stat reload.
+            removeModifier(modifier.name(), false, map, levels);
         }
         map.put(modifier.name(), modifier);
         if (levels != null) {