Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

182 bug analytics app doesnt display aggregate data with sqlite backend #183

Merged
merged 5 commits into from
Jun 19, 2024
Merged

182 bug analytics app doesnt display aggregate data with sqlite backend #183

merged 5 commits into from
Jun 19, 2024

Conversation

Gotfrid
Copy link
Member

@Gotfrid Gotfrid commented Jun 17, 2024 •
edited
Loading

Closes #182

Changes description

Fix SQLite backend - correctly read datetime values.

Definition of done

  • Have you read the Contributing Guidelines?
  • NEWS.md file has been updated
  • Development version has been bumped (x.y.z.90XX)
  • Issue has been linked with this PR (via Closing keywords or right sidebar under Development)

How to test

devtools::load_all()

# run some events
shiny::shinyAppFile(system.file("examples", "sqlite", "sqlite_app.R", package = "shiny.telemetry"))

# test that the behavior described in the issue 
shiny::shinyAppFile(system.file("examples", "sqlite", "sqlite_analytics.R", package = "shiny.telemetry"))
Screenshot 2024-06-17 at 16 41 05

@Gotfrid
fix: ensure correct sqlite timestamp parsing
72bb34e 
this is achieved by overriding read_data method in DataStorageSQLite
class
to ensure that when the `time` column is later coverted
using `lubridate::as_date()` it correctly returns date value.
@Gotfrid
chore: scaffold example sqlite app
051385c
@Gotfrid Gotfrid linked an issue Jun 17, 2024 that may be closed by this pull request
[Bug]: Analytics app doesn't display aggregate data with SQLite backend #182
Closed
1 task
@Gotfrid Gotfrid mentioned this pull request Jun 17, 2024
Closed
1 task
@averissimo averissimo marked this pull request as ready for review June 19, 2024 11:51
averissimo
averissimo approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch on this bug and I ❤️ the simplicity of the fix.

I've added sanity tests that will be run for all storage backends

@averissimo averissimo self-assigned this Jun 19, 2024
@Gotfrid Gotfrid merged commit d433144 into main Jun 19, 2024
8 checks passed
@Gotfrid Gotfrid deleted the 182-bug-analytics-app-doesnt-display-aggregate-data-with-sqlite-backend branch June 19, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averissimo averissimo averissimo approved these changes

Assignees

@averissimo averissimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Analytics app doesn't display aggregate data with SQLite backend
2 participants
@Gotfrid @averissimo