Usage of dynamic dots in router_ui
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanhry
changed the title
router_uirouter_ui
jakubnowicki
requested changes
Apr 5, 2023
R/router.R
Outdated
Comment on lines
185
to
187
| #' @param ... <[`dynamic-dots`][rlang::dyn-dots]> | ||
| #' All other routes defined with shiny.router::route function. | ||
| #' It's possible to pass routes in dynamic way with dynamic dots |
There was a problem hiding this comment.
Please remove the beginning (<[dynamic-dots][rlang::dyn-dots]>). Instead, after mentioning the possibility to use dynamic dots please:
- provide a link to
rlangdocumentation with dynamic dots explanation - mention the example
There was a problem hiding this comment.
Done, should I somehow add the link to the file in examples/?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
...argument inrouter_uito allow dynamically pass arguments