Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support typescript definition #110

Merged
merged 3 commits into from
Feb 12, 2020
Merged

support typescript definition #110

merged 3 commits into from
Feb 12, 2020

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented Sep 26, 2019

No description provided.

@bang9 bang9 changed the title Create index.d.ts support typescript definition Oct 15, 2019
@ghost
Copy link

ghost commented Feb 5, 2020

@wesfieldj Hello! Any plans on merging this in the near future? I see that PR is here from September and might be out of date already, so could you please let us know what is the blocker for merging TS definitions and if you need any additional help on this? Would be cool to have it merged. Thank you!

@wesfieldj
Copy link
Contributor

@shaikou Looking into it now. Sorry for the delay.

@bang9
Copy link
Contributor Author

bang9 commented Feb 6, 2020

@wesfieldj @shaikou Updated to the latest version !

@fabianlee1211
Copy link

fabianlee1211 commented Feb 6, 2020

Should have check if there is a PR already. 🙍‍♂
I made one on DefinitelyTyped, formatted and passed their test.
Perhaps we could merge our good stuff into one?

Update: My PR has been merged. It’s available at ‘@types/react-native-appsflyer’.
DefinitelyTyped/DefinitelyTyped#42158

@bang9
Copy link
Contributor Author

bang9 commented Feb 11, 2020

Should have check if there is a PR already. 🙍‍♂
I made one on DefinitelyTyped, formatted and passed their test.
Perhaps we could merge our good stuff into one?

Update: My PR has been merged. I suppose it would be available under ‘@ types’ soon.
DefinitelyTyped/DefinitelyTyped#42158

@fabianlee1211
SHA256 not supported yet in react-native-appsflyer iOS
I think you should fix the SHA256 in EmailCryptType enum
check #141

@fabianlee1211
Copy link

Should have check if there is a PR already. 🙍‍♂
I made one on DefinitelyTyped, formatted and passed their test.
Perhaps we could merge our good stuff into one?
Update: My PR has been merged. I suppose it would be available under ‘@ types’ soon.
DefinitelyTyped/DefinitelyTyped#42158

@fabianlee1211
SHA256 not supported yet in react-native-appsflyer iOS
I think you should fix the SHA256 in EmailCryptType enum
check #141

Thanks mate! I guess I would keep it there because it wouldn't be a breaking problem. I believe your iOS PR will be merged soon!

@wesfieldj wesfieldj merged commit f63a871 into AppsFlyerSDK:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants