Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create appimage files within ubuntu-18.04 since ~2023-09-12 #544

Closed
uli-heller opened this issue Oct 9, 2023 · 4 comments · Fixed by #545
Closed

Unable to create appimage files within ubuntu-18.04 since ~2023-09-12 #544

uli-heller opened this issue Oct 9, 2023 · 4 comments · Fixed by #545

Comments

@uli-heller
Copy link
Contributor

uli-heller commented Oct 9, 2023

VSCODIUM uses ubuntu-18.04 for its build. Since a couple of weeks, building the appimage fails.
I guess this is due to a new version of pkg2appimage. I can reproduce the failure. Using ubuntu-18.04 fails building appimage files.
Using ubuntu-20.04, appimage files can be created.

Since VSCODE uses ubuntu-18.04 for its build at the moment, I guess VSCODIUM should use the same version.

I created a custom version of pkg2appimage. Using this version, the build succeeds under ubuntu-18.04. I'll create a pull request
for the version. Maybe you can accept the PR?

I case of questions, please drop me a note. I can provide lots of more details and informations

VSCodium/vscodium#1654

@probonopd
Copy link
Member

So this is the change?

master...uli-heller:pkg2appimage:master

@GitMensch
Copy link

Yes, see the linked PR.

Korne127 added a commit to Korne127/pkg2appimage that referenced this issue Jul 23, 2024
libthai.so.0 has been removed from the excludelist.
The original reason why libthai has been added to it is an issue that occurs when libpango is not bundled but libthai is (see AppImageCommunity#538). But since then, libpango has been removed from the excludelist in 2022. This means that the original reason why libthai has been excluded is no longer relevant. Therefore it could be removed from the excludelist. This fixes AppImageCommunity#544.

Additionally, the excludelist formatting has been improved. There had been different places scattered across the excludelist in which libraries have been excluded or not excluded due to other libraries (like libthai / libpango). They have all been brought together (with all information and reasoning) in one block to prevent issues like this in the future.
Additionally, missing information out of AppImageCommunity#528 has been added to this block.
Korne127 added a commit to Korne127/pkg2appimage that referenced this issue Jul 23, 2024
libthai.so.0 has been removed from the excludelist.
The original reason why libthai had been added to it is an issue that occurs when libpango is not bundled but libthai is (see AppImageCommunity#538). But since then, libpango had been removed from the excludelist in 2022. This means that the original reason why libthai had been excluded is no longer relevant. Therefore it could be removed from the excludelist. This fixes AppImageCommunity#544.

Additionally, the excludelist formatting has been improved. There had been different places scattered across the excludelist in which libraries had been excluded or not excluded due to other libraries (like libthai / libpango). They have all been brought together (with all information and reasoning) in one block to prevent issues like this in the future.
Additionally, missing information out of AppImageCommunity#528 has been added to this block.
@Korne127
Copy link
Contributor

Whoops sorry, accidentally pasted the wrong number 😅

@probonopd
Copy link
Member

Ubuntu 18.04 ran out of standard support in April 2023. Currently we are targeting Ubuntu 20.04.

https://ubuntu.com/about/release-cycle

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants