Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build issue on Alpinelinux #1019

Merged
merged 4 commits into from
Feb 18, 2020
Merged

Conversation

zaoqi
Copy link
Contributor

@zaoqi zaoqi commented Dec 15, 2019

@probonopd
Copy link
Member

Do you see any issues with this @TheAssassin?

src/light_elf.h Outdated Show resolved Hide resolved
@TheAssassin
Copy link
Member

@probonopd the change itself is harmless, it won't interfere with our build system (if that macro doesn't exist, the extern C will just be ignored). However it doesn't quite seem right. @zaoqi please double-check your commit.

@TheAssassin TheAssassin merged commit 20ea487 into AppImage:master Feb 18, 2020
@probonopd
Copy link
Member

Thank you very much gentlemen 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants