Handle nested inner exceptions #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replicate behaviour of v7 policies and recursively check all inner exceptions and `AggregateException` to handle inner exceptions. - Refactor predicate builder test cases to make a bit more readable. - Use collection expression. Resolves App-vNext#2161.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2166 +/- ##
==========================================
+ Coverage 83.78% 83.80% +0.02%
==========================================
Files 313 313
Lines 7152 7163 +11
Branches 1057 1061 +4
==========================================
+ Hits 5992 6003 +11
Misses 789 789
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add more test coverage for nested exceptions.
Add a unit test for a `AggregateException` with no inner exeptions.
martintmk
approved these changes
Jun 28, 2024
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AggregateExceptionto handle inner exceptions.Resolves #2161.