Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async void usage #2013

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

martincostello
Copy link
Member

Remove tests using async void that shouldn't be.

dotnet/extensions#4985 (comment)

Remove tests using `async void` that shouldn't be.
@martincostello martincostello enabled auto-merge (rebase) March 7, 2024 19:04
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (77cfe6d) to head (d1af59b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2013   +/-   ##
=======================================
  Coverage   83.64%   83.64%           
=======================================
  Files         312      312           
  Lines        7105     7105           
  Branches     1054     1054           
=======================================
  Hits         5943     5943           
  Misses        789      789           
  Partials      373      373           
Flag Coverage Δ
linux 83.64% <ø> (ø)
macos 83.64% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit ef14f72 into App-vNext:main Mar 7, 2024
14 checks passed
@martincostello martincostello deleted the remove-async-void branch March 7, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant