Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaos API review pass #1934

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Chaos API review pass #1934

merged 2 commits into from
Jan 27, 2024

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jan 27, 2024

Pull Request

The issue or feature being addressed

Contributes to #1901

Details on the issue fix or feature implementation

I went through the Chaos API but haven't found any inconsistencies anymore outside of XML docs.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added this to the v8.3.0 milestone Jan 27, 2024
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7271647) 84.81% compared to head (a6cdc07) 84.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1934      +/-   ##
==========================================
- Coverage   84.81%   84.81%   -0.01%     
==========================================
  Files         312      312              
  Lines        6901     6900       -1     
  Branches     1056     1056              
==========================================
- Hits         5853     5852       -1     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 84.81% <100.00%> (-0.01%) ⬇️
macos 84.81% <100.00%> (-0.01%) ⬇️
windows 84.81% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk merged commit 0064b4d into main Jan 27, 2024
17 checks passed
@martintmk martintmk deleted the mtomka/chaos-review-pass branch January 27, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants