Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop OutcomeArguments struct #1513

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Drop OutcomeArguments struct #1513

merged 1 commit into from
Aug 24, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 24, 2023

Details on the issue fix or feature implementation

For context:
#1507 (comment)

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 24, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1513 (e771ba1) into main (8aa9df2) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
+ Coverage   84.02%   84.10%   +0.08%     
==========================================
  Files         274      277       +3     
  Lines        6547     6581      +34     
  Branches     1024     1025       +1     
==========================================
+ Hits         5501     5535      +34     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 84.10% <100.00%> (+0.08%) ⬆️
windows 84.10% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/PredicateBuilder.TResult.cs 100.00% <ø> (ø)
...CircuitBreaker/CircuitBreakerPredicateArguments.cs 100.00% <100.00%> (ø)
...CircuitBreaker/CircuitBreakerResilienceStrategy.cs 100.00% <100.00%> (ø)
...itBreaker/CircuitBreakerStrategyOptions.TResult.cs 100.00% <100.00%> (ø)
...ircuitBreaker/Controller/CircuitStateController.cs 100.00% <100.00%> (ø)
...ly.Core/CircuitBreaker/OnCircuitClosedArguments.cs 100.00% <100.00%> (ø)
...ly.Core/CircuitBreaker/OnCircuitOpenedArguments.cs 100.00% <100.00%> (ø)
src/Polly.Core/Fallback/FallbackHandler.cs 100.00% <100.00%> (ø)
.../Polly.Core/Fallback/FallbackPredicateArguments.cs 100.00% <100.00%> (ø)
.../Polly.Core/Fallback/FallbackResilienceStrategy.cs 100.00% <100.00%> (ø)
... and 19 more

@martintmk martintmk enabled auto-merge (squash) August 24, 2023 14:19
@martintmk martintmk merged commit 60288c8 into main Aug 24, 2023
12 checks passed
@martintmk martintmk deleted the mtomka/drop-outcomearguments branch August 24, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants