Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor API cleanup #1508

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Minor API cleanup #1508

merged 1 commit into from
Aug 23, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 23, 2023

Details on the issue fix or feature implementation

Contributes to #1507

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 23, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1508 (71db9fe) into main (a61b343) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1508   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         272      272           
  Lines        6481     6481           
  Branches     1020     1020           
=======================================
  Hits         5435     5435           
  Misses        837      837           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 83.86% <100.00%> (ø)
windows 83.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/Retry/OnRetryArguments.cs 100.00% <100.00%> (ø)
src/Polly.Testing/ResiliencePipelineDescriptor.cs 100.00% <100.00%> (ø)
src/Polly.Testing/ResilienceStrategyDescriptor.cs 100.00% <100.00%> (ø)

@martintmk martintmk enabled auto-merge (squash) August 23, 2023 08:04
@martintmk martintmk merged commit b91fb46 into main Aug 23, 2023
12 checks passed
@martintmk martintmk deleted the mtomka/minor-api-cleanup branch August 23, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants