Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pipeline-related internals into Pipeline folder #1497

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 17, 2023

Details on the issue fix or feature implementation

Internal only changes. To improve organization the pipeline-related APIs have been moved to PipelineFolder.
I have also introduced the static PipelineComponentFactory that creates pipeline components.

No other changes to files, shame that git is unable to match these changes as renames.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 17, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1497 (8ed97f1) into main (149ed82) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1497      +/-   ##
==========================================
- Coverage   83.88%   83.88%   -0.01%     
==========================================
  Files         269      273       +4     
  Lines        6492     6491       -1     
  Branches     1024     1024              
==========================================
- Hits         5446     5445       -1     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
macos 83.88% <100.00%> (-0.01%) ⬇️
windows 83.88% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/ResiliencePipeline.cs 100.00% <ø> (ø)
src/Polly.Core/ResiliencePipelineT.cs 100.00% <ø> (ø)
...olly.Core/Utils/Pipeline/ComponentDisposeHelper.cs 100.00% <ø> (ø)
.../Polly.Core/Registry/ResiliencePipelineRegistry.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipeline.Async.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipeline.AsyncT.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipeline.Sync.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipeline.SyncT.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipelineBuilderBase.cs 100.00% <100.00%> (ø)
.../Polly.Core/ResiliencePipelineBuilderExtensions.cs 100.00% <100.00%> (ø)
... and 9 more

@martintmk martintmk enabled auto-merge (squash) August 17, 2023 12:55
@martintmk martintmk merged commit c21a307 into main Aug 17, 2023
12 checks passed
@martintmk martintmk deleted the mtomka/pipeline-folder branch August 17, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants