Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused ResiliencePipelineRegistry APIs #1495

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 17, 2023

Details on the issue fix or feature implementation

This makes the registry append-only.

One reason the removals might not be required is the built-in dynamic reload support. Instead of removing, re-creating and adding the pipeline back, it's cleaner and safer to just tell the registry to reload the pipeline.

If there is a feature request for it, we can add these APIs easily back.

Contributes to #1233

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 17, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1495 (819e4a2) into main (57c540d) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1495      +/-   ##
==========================================
- Coverage   83.64%   83.59%   -0.05%     
==========================================
  Files         268      268              
  Lines        6394     6377      -17     
  Branches     1007     1007              
==========================================
- Hits         5348     5331      -17     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux 83.59% <ø> (-0.05%) ⬇️
macos 83.59% <ø> (-0.05%) ⬇️
windows 83.59% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ore/Registry/ResiliencePipelineRegistry.TResult.cs 100.00% <ø> (ø)
.../Polly.Core/Registry/ResiliencePipelineRegistry.cs 100.00% <ø> (ø)
...dencyInjection/PollyServiceCollectionExtensions.cs 100.00% <ø> (ø)

@martintmk martintmk merged commit 46dc47f into main Aug 17, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/registry-cleanup branch August 17, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants