Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide validation APIs #1490

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Hide validation APIs #1490

merged 1 commit into from
Aug 15, 2023

Conversation

martintmk
Copy link
Contributor

Details on the issue fix or feature implementation

Polly infra already validates all necessary options automatically. It was exposed only to validate TelemetryOptions but we can do it by linking internals.

If someone really needs it we can re-expose the API.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk self-assigned this Aug 15, 2023
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 15, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1490 (d12ce7a) into main (72e5599) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1490   +/-   ##
=======================================
  Coverage   83.71%   83.71%           
=======================================
  Files         272      272           
  Lines        6424     6424           
  Branches     1012     1012           
=======================================
  Hits         5378     5378           
  Misses        837      837           
  Partials      209      209           
Flag Coverage Δ
linux 83.71% <100.00%> (ø)
macos 83.71% <100.00%> (ø)
windows 83.71% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/ResiliencePipelineBuilderBase.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceValidationContext.cs 100.00% <100.00%> (ø)
...ry/TelemetryResiliencePipelineBuilderExtensions.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit fc8642b into main Aug 15, 2023
16 checks passed
@martintmk martintmk deleted the mtomka/hide-validation-apis branch August 15, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants