Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1099

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Update README.md #1099

merged 3 commits into from
Apr 5, 2023

Conversation

kmgallahan
Copy link
Contributor

The issue or feature being addressed

On starting into the README I saw it could use a TOC.

Details on the issue fix or feature implementation

On adding a TOC I saw some header issues.

On working through the header issues I found some organizational opportunities.

I think these changes should help newcomers (like me) trying to work through the giant README.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

On starting into the README I saw it could use a TOC.

On adding a TOC I saw some header issues.

On working through the header issues I found some organizational opportunities.

I think these changes should help newcomers (like me) trying to work through the giant README.
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Just a few minor comments.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Add extension used to maintain the new TOC.
Copy link
Contributor Author

@kmgallahan kmgallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions implemented.

Suggestions implemented

Co-authored-by: Martin Costello <martin@martincostello.com>
@martincostello martincostello enabled auto-merge (squash) April 5, 2023 14:44
@martincostello martincostello merged commit 40606d2 into App-vNext:main Apr 5, 2023
@martincostello
Copy link
Member

Thanks!

@kmgallahan kmgallahan deleted the patch-1 branch April 5, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants