Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multitenancy #3679

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Conversation

carlesarnal
Copy link
Member

@carlesarnal carlesarnal commented Sep 21, 2023

This PR removes all the bits related to multitenancy.

To be able to do it, the automatic upgrade process is removed as well, since removing multitenancy is a breaking change from a data structure perspective. Therefore, all the upgrade scripts have been removed as well since once this is merged the only way to migrate the data will be the import/export feature. This raises the question of whether to restart the database version number since all the installations using version 3 will be fresh installations without the old automatic database structure migration process. I decided to reset it in this PR, but that can be reverted very easily.

@apicurio-bot
Copy link

apicurio-bot bot commented Sep 21, 2023

Thank you for creating a pull request!

Pinging @EricWittmann to respond or triage.

Copy link
Member

@jsenko jsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the workflow succeeds

EricWittmann
EricWittmann previously approved these changes Sep 22, 2023
@carlesarnal carlesarnal merged commit 7cecfa9 into Apicurio:main Oct 3, 2023
20 checks passed
@carlesarnal carlesarnal deleted the remove-multitenancy branch October 3, 2023 11:00
@carlesarnal carlesarnal linked an issue Oct 6, 2023 that may be closed by this pull request
@pantaoran
Copy link

I'm confused, why is multitenancy being removed? Will this no longer be a feature?
I mean, it was actually never really a feature since it was never really documented. However, I want to have some authorization features, and since I have an API Gateway in front of Apicurio which takes care of authentication, multitenancy looked very promising.
Should I abort my efforts to get MT to work, since it will be removed in v3?

@EricWittmann
Copy link
Member

I responded to this in an old discussion thread as well but happy to respond here as well.

Yes, in 3.0 we have removed the multi-tenant feature. The reason for this is that we didn't have any community desire for it, and the Red hat product that required it was decommissioned.

That said, if there is a community need we could revisit and re-implement.

If your need is more authorization based, I think we might prefer to collaborate on that rather than reintroduce multitenancy. Could you open a new GitHub issue or discussion thread on this topic? Perhaps you can explain your specific use case and we can see what we can do. We know that our authorization story needs to be better than it is.

@pantaoran
Copy link

Thank you very much for your reply. Your confirmation saves me the time of getting MT to work in the 2.x versions, knowing now that it will never be officially available.

I have therefore created #5125 to detail my needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for Multitenancy
4 participants