-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove multitenancy #3679
Remove multitenancy #3679
Conversation
Thank you for creating a pull request! Pinging @EricWittmann to respond or triage. |
d728472
to
9cd6f18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the workflow succeeds
app/src/main/java/io/apicurio/registry/storage/impl/sql/AbstractSqlRegistryStorage.java
Show resolved
Hide resolved
981fa20
to
d7534c1
Compare
I'm confused, why is multitenancy being removed? Will this no longer be a feature? |
I responded to this in an old discussion thread as well but happy to respond here as well. Yes, in 3.0 we have removed the multi-tenant feature. The reason for this is that we didn't have any community desire for it, and the Red hat product that required it was decommissioned. That said, if there is a community need we could revisit and re-implement. If your need is more authorization based, I think we might prefer to collaborate on that rather than reintroduce multitenancy. Could you open a new GitHub issue or discussion thread on this topic? Perhaps you can explain your specific use case and we can see what we can do. We know that our authorization story needs to be better than it is. |
Thank you very much for your reply. Your confirmation saves me the time of getting MT to work in the 2.x versions, knowing now that it will never be officially available. I have therefore created #5125 to detail my needs. |
This PR removes all the bits related to multitenancy.
To be able to do it, the automatic upgrade process is removed as well, since removing multitenancy is a breaking change from a data structure perspective. Therefore, all the upgrade scripts have been removed as well since once this is merged the only way to migrate the data will be the import/export feature. This raises the question of whether to restart the database version number since all the installations using version 3 will be fresh installations without the old automatic database structure migration process. I decided to reset it in this PR, but that can be reverted very easily.