Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Storybook] Fix stories containing Modal components (Shopify#10492)
### WHY are these changes introduced? Due to a recent update to the Dialog component within the Modal, it now uses the `useFrame` hook. Due to this, we need to ensure that anywhere it's used, we have a parent `<Frame>` component anywhere. This is not an issue for production, where the `<Frame>` is automatically included by the `<AppProvider>` or for tests where `mountWithApp` includes the `<Frame>`, but I noticed some Storybook stories breaking. So we wrap all stories in a `<FrameContext.Provider>` component now. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) - Go to Storybook generated by Chromatic - Go to the Banner -> In a Modal story - It should work fine - Go to the IndexFilters stories - Launch the Create new View modal - They should work fine - Go to the IndexTable stories that contain the filtering element - Launch the Create new View modal - They should work fine ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
- Loading branch information