Skip to content

Commit

Permalink
[ProgressBar] Consolidate se23 logic and styles (Shopify#10130)
Browse files Browse the repository at this point in the history
### WHY are these changes introduced?

Fixes Shopify#9959

### WHAT is this pull request doing?

Consolidate se23 logic and styles for `PageActions` Component

### How to 🎩
Compare production and this PR's chromatic storybook to make sure styles
are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-progressbar--default&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-lasqorkejk.chromatic.com/?path=/story/all-components-progressbar--default)
  • Loading branch information
sophschneider committed Aug 21, 2023
1 parent 2d48639 commit 329385f
Showing 1 changed file with 3 additions and 18 deletions.
21 changes: 3 additions & 18 deletions polaris-react/src/components/ProgressBar/ProgressBar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,8 @@
.toneHighlight {
// stylelint-disable -- Polaris component custom properties
--pc-progress-bar-background: var(--p-color-bg-strong);
--pc-progress-bar-indicator: var(--p-color-border-info);
--pc-progress-bar-indicator: var(--p-color-bg-info-strong);
// stylelint-enable

#{$se23} & {
// stylelint-disable-next-line -- Polaris component custom properties, se23 temporary styles
--pc-progress-bar-indicator: var(--p-color-bg-info-strong);
}
}

.tonePrimary {
Expand All @@ -57,25 +52,15 @@
.toneSuccess {
// stylelint-disable -- Polaris component custom properties
--pc-progress-bar-background: var(--p-color-bg-strong);
--pc-progress-bar-indicator: var(--p-color-border-success);
--pc-progress-bar-indicator: var(--p-color-bg-success-strong);
// stylelint-enable

#{$se23} & {
// stylelint-disable-next-line -- Polaris component custom properties, se23 temporary styles
--pc-progress-bar-indicator: var(--p-color-bg-success-strong);
}
}

.toneCritical {
// stylelint-disable -- Polaris component custom properties
--pc-progress-bar-background: var(--p-color-bg-strong);
--pc-progress-bar-indicator: var(--p-color-bg-critical);
--pc-progress-bar-indicator: var(--p-color-bg-critical-strong);
// stylelint-enable

#{$se23} & {
// stylelint-disable-next-line -- Polaris component custom properties, se23 temporary styles
--pc-progress-bar-indicator: var(--p-color-bg-critical-strong);
}
}

.Indicator {
Expand Down

0 comments on commit 329385f

Please sign in to comment.