Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Svelte.js #167

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Conversation

benwoodward
Copy link
Contributor

Just duplicated the Vue.js configs. Seems to work.

Basically just duplicated Vue configs
@AndrewRadev
Copy link
Owner

I'm not very familiar with Svelte, but I can see that it's similar to Vue in expecting script and style tags and HTML in one file. So I can see how it would work. I'm happy to include it.

That said, what do you think about directly including the vue.js support file instead? So, instead of that code, this should work the same way:

runtime ftplugin/vue/splitjoin.vim

The benefit is if any more Vue support is added, or if the callbacks are reordered to fix a bug, Svelte should work the same way. The drawback is that if we ever want to add Svelte-specific support, we'd have to go back to copy-pasting the code, but then we'd be in the same position anyway.

What do you think?

@benwoodward
Copy link
Contributor Author

Yep, makes a lot of sense. Tested it, works, made a commit.

@AndrewRadev
Copy link
Owner

Thanks, I'll go ahead and merge then 👍

@AndrewRadev AndrewRadev merged commit ae8b525 into AndrewRadev:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants