Update the version in the control file on a new release #171
Conversation
walkero-gr
requested review from
afxgroup,
3246251196,
migthymax and
josefwegner
| @@ -240,6 +240,7 @@ ifdef GITTAG | |||
| $(VERBOSE)sed -i 's/REVISION\t*[[:digit:]]/REVISION\t\t$(MINOR)/g' library/c.lib_rev.h | |||
| $(VERBOSE)sed -i 's/SUBREVISION\t*[[:digit:]]/SUBREVISION\t\t$(PATCH)/g' library/c.lib_rev.h | |||
| $(VERBOSE)sed -i 's/clib4.library [0-9]*\.[0-9]*\.[0-9]*/clib4.library $(MAJOR).$(MINOR).$(PATCH)/g' library/c.lib_rev.h | |||
| $(VERBOSE)sed -i 's/Version: [0-9]*\.[0-9]*\.[0-9]*/Version: $(MAJOR).$(MINOR).$(PATCH)/g' misc/control | |||
There was a problem hiding this comment.
Nitpick alert:
I would update the regexp to s/Version: [0-9]+\.[0-9]+\.[0-9]+/Version: $(MAJOR).$(MINOR).$(PATCH)/g
The change is that the regexp now requires at least on digit for MAJOR, MINOR and PATCH.
There was a problem hiding this comment.
I was thinking to use [[:digit:]], and that should work fine, unless if someone goes and update manually that file to something like 1.10.0. That would make this update fail. That's what I wanted to avoid.
There was a problem hiding this comment.
Using [[:digit:]]\+ should do want you want. It will also match 1+ digits.
|
However this makes sense if we use the third digit but I don't know if it is needed on clib4 since OS4 doesn't supports it. We have onlt VERSION and REVISION except if we use it as description when using FULL parameter in version |
When a new release is initiated, the
misc/controlfiles needs to be updated as part of the process. This is used when the Ubuntu APT package is created.