Improve the speed of some post-cluster calculations #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with sieve status of each frame
way it only needs to be generated once. It may be better to just have it generated all the time.
rep found when doing best rep search for cluster by parts and all frames just happen to be sieved out
Not sure why I wasn't doing this already...
for cluster silhouette frame output.
best reps for split, fix frame index in silhouette calc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 6.2.0.
Certain post-clustering actions (such as the cluster summary, best representatives frame calculation, and cluster silhouette calculation) became very expensive for high frame counts when sieving was used due to reliance on a
O(N)scaling function. This has been replaced in many instances with a boolean array, greatly improving speed at the cost of some memory.Also fixes best representative frames calculation for the summary by parts (
summarysplit).Also adds a new option to control the index written to the cluster frame silhouette file:
[silidx {idx|frm}], whereidxindicates the sorted index should be used (this is what had been used) andfrmindicates the actual frame number should be used.