new concept #784
Draft
new concept #784
+269
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public void Configure(MvcOptions options) | ||
| { | ||
| var jsonOptions = _jsonOptions.Get(_jsonSettingsName); | ||
| var logger = _loggerFactory.CreateLogger<EnumAsNumberFormatter>(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
| } | ||
| } | ||
|
|
||
| internal class EnumToNumberJsonConverter<TEnum> : JsonConverter<TEnum> |
There was a problem hiding this comment.
Do we need a custom converter? Isn't number encoding the default?
| @@ -21,6 +22,7 @@ namespace Altinn.App.Api.Controllers; | |||
| /// </summary> | |||
| [Authorize] | |||
| [ApiController] | |||
| [JsonSettingsName("EnumAsNumber")] | |||
There was a problem hiding this comment.
Maybe the setting name should just be AltinnApis or something? Denoting that whatever settings are injected are what is required to make our own APIs stable?
Now maybe we should consider API conventions as well so that we don't have to remember this attribute everywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a new solution, compare to #773.
Here we annotate controllers. This means we do not have to update all enums with an annotation and remember it for future enums, and do the same for enums from storage/platform.
The tradeoff is the scaffolding to make this happen.
See PartiesController for usage.
Related Issue(s)
Verification
Documentation